refactor(modal-backdrop): make backdrop use bootstrap color#20
Open
dankahle wants to merge 2 commits intomgcrea:masterfrom
Open
refactor(modal-backdrop): make backdrop use bootstrap color#20dankahle wants to merge 2 commits intomgcrea:masterfrom
dankahle wants to merge 2 commits intomgcrea:masterfrom
Conversation
Change backdrop to use bootstrap color instead. Fixes: mgcrea#18
keep webstorm files out of changelist
dankahle
changed the title
Author
|
To do this right would mean to have this code in "all" of the animations as the modal options.backdropAnimation allows it, but you haven't done that and not sure it would ever be needed. I did a modal background am-flipx the other day and it looked about as funny as you can imagine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
Looked into this issue. Was confused by the angular-strap modal docs which give you backdrop transition code, yet afford you the backdrop animation in angular-motion's am-fade code. It would be best to supply this animation for them, instead of having them have to manually put it in themselves. Maybe some people don't use angular-motion though and that's what the AS doc's transition code is all about? Tried to use the transition code here, but ran into am-fade animation code that was running in parallel, so went with animation instead. Copied the am-fade animation style with visibility and backwards fill-mode, though not sure why either one of those are there. Maybe you can clarify the need, i.e. works without visibility settings and fill-mode:none (to override am-fade's fill-mode application).
I'm not sure where all this code is used, all I know about is angular-strap. The tests are broken on a need for the karma-jasmine plugin, but didn't see any tests anyway. I tested it on angular-strap running on bootstrap 3.2.0 as the modal background still isn't fixed on bootstrap 3.3.2 last time I checked.